-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring: Simplify MockDeploymentBackend #5056
Merged
jnm
merged 11 commits into
kobocat-django-app-part-2-remove-service-account
from
kobocat-django-app-part-2-refactor-mock-deployment-backend
Oct 3, 2024
Merged
Code refactoring: Simplify MockDeploymentBackend #5056
jnm
merged 11 commits into
kobocat-django-app-part-2-remove-service-account
from
kobocat-django-app-part-2-refactor-mock-deployment-backend
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
Kobocat django app part 2 refactor mock deployment backend
Code refactoring: Simply MockDeploymentBackend
Aug 8, 2024
noliveleger
changed the title
Code refactoring: Simply MockDeploymentBackend
Code refactoring: Simplify MockDeploymentBackend
Aug 8, 2024
This was referenced Aug 8, 2024
noliveleger
force-pushed
the
kobocat-django-app-part-2-refactor-mock-deployment-backend
branch
from
August 8, 2024 20:37
0da213d
to
f68c59b
Compare
noliveleger
force-pushed
the
kobocat-django-app-part-2-refactor-mock-deployment-backend
branch
from
August 8, 2024 21:00
f68c59b
to
be7505e
Compare
noliveleger
changed the base branch from
kobocat-django-app-part-2
to
kobocat-django-app-part-2-remove-service-account
August 8, 2024 21:01
1 similar comment
…kobocat-django-app-part-2-refactor-mock-deployment-backend
jnm
requested changes
Sep 20, 2024
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-service-account
branch
from
October 3, 2024 21:24
59a00a6
to
41c6b73
Compare
jnm
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 ✔️
jnm
merged commit Oct 3, 2024
78ee7d8
into
kobocat-django-app-part-2-remove-service-account
4 checks passed
jnm
deleted the
kobocat-django-app-part-2-refactor-mock-deployment-backend
branch
October 3, 2024 21:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part VII of #5036.
Notes
Remove (almost) every mocked object, function, class etc... from
MockDeploymentBackend
.All tests are using the same deployment mechanism than production which gives us a better test coverage.
The counterpart, it takes longer to run the whole suite without any parallel mechanism (such as
py-xdist
plugin).Related issues
Part of #5036